"Firefox 2 theme for Firefox 3.x" version 0.9.5 out
Submitted by fabio on Wed, 2009-08-12 16:24.
I just pushed to addons.mozilla.org version 0.9.5 of the Firefox 2 theme for Firefox 3.x.
You can find the new version attached here or at addons.mozilla.org.
As always, please send me any bugs or improvements you might find commenting below. Thanks.
| Attachment | Size |
|---|---|
| firefox_2_theme_for_firefox_3-0.9.5-fx.jar | 648.37 KB |
- fabio's blog
- 1176 reads
Posted in:
Menu title text no longer changes color when selected
On Linux, with no system theme set (since that's the whole reason I use this FF theme: I don't want to deal with compiling all of gnome or kde to be able to get a "system theme", and without one, FF3 looks even more horrible).
When I select a menu -- say, "File" -- older versions of this theme (up to 0.9.4b) made the text of that menu item white. 0.9.5 leaves it black. (It's black when not selected, which is fine.) Any way to fix?
(I should note: the individual menu items still look and act fine: they change to white when highlighted. It's only the top-level menu items that keep their current text color.)
I said that "is the correct
I said that "is the correct behavior" because every other GTK or QT based apps on my system don't change the text color. Then having Firefox doing the same looks like the correct behavior to me.
What other apps does on your system? Eg what does GIMP?
Hmm. The screenshot you
Hmm.
The screenshot you posted has a much lighter-colored highlight than what I get here. This is why it looks OK to you. (The color here is #4b6983, according to gimp and a screenshot.) As far as other GTK2 programs -- gimp turns the text white. So does gvim. Both use the same (darker) highlight color. :-)
However, this is gtk 2.10.3. It's possible that newer versions act differently now; it has been quite a while since I installed that.
I'll look into the user CSS file. Thanks!
If all other applications
If all other applications have a different behavior on the menu text of Firefox than this is definitely a bug of the theme.
The theme should do the same as your other applications, not something else.
Please upgrade your GTK install, just to check that it is not related to that .. and then let me know what happens.
I'll try to get a completely gnome and kde naked and use the theme there. Let's see what happens.
Thanks for your contribution.
Looks like the userChrome.css
Looks like the userChrome.css (somewhat modified) worked. Here's what I had to do:
menubar > menu[open] {
color: -moz-menuhovertext !important;
background-color: -moz-menuhover !important;
}
(Specifically, I had to "!important", to override yours.)
Yeah. I forgot the !important
Yeah. I forgot the !important bit.
Actually having the text
Actually having the text black even when selected is the correct behavior. I usually use the theme on Arch Linux and Ubuntu and that's the color I always get starting on 0.9.3 to 0.9.5.
This is how it looks on my systems:
The only modifications I did was this piece of code in chrome/browser/browser.css:
menubar > menu[_moz-menuactive="true"], menubar > menu[_moz-menuactive="true"][open="true"] { color: MenuText !important; /* Fix white text on menus */ }You can remove that or you can add these lines to userChrome.css:
menubar > menu[open] { color: -moz-menuhovertext; background-color: -moz-menuhover; }Modifying userChrome.css is preferable as you don't modify the original code and the modification will work also when the theme is updated.
The correct userChrome.css
The correct userChrome.css is:
menubar > menu[open] { color: -moz-menuhovertext !important; background-color: -moz-menuhover !important; }Love the theme, but what
Love the theme, but what happened to the new tab button on the tabbar? It disappears when I use this theme.
Post new comment